Skip to content

Remove thiserror and ordered-float crates#11

Merged
sile merged 2 commits intomasterfrom
remove-thiserror
Mar 16, 2025
Merged

Remove thiserror and ordered-float crates#11
sile merged 2 commits intomasterfrom
remove-thiserror

Conversation

@sile
Copy link
Copy Markdown
Owner

@sile sile commented Mar 16, 2025

Copilot Summary

This pull request includes several changes to improve error handling and modify the Float struct in the Rust codebase. The most important changes include removing the thiserror dependency, implementing custom error handling for DecodeError and EncodeError, and updating the Float struct to ensure consistent hashing and equality checks.

Error handling improvements:

  • src/codec.rs: Removed the thiserror dependency and implemented custom Display and Error traits for DecodeError and EncodeError enums.

Codebase simplification:

Float struct modifications:

  • src/lib.rs: Added PartialEq derive to Float struct.
  • src/lib.rs: Removed manual PartialEq implementation for Float and updated Hash implementation to handle special cases like NaN and zero values.

@sile sile changed the title Remove thiserror and ordered-floats Remove thiserror and ordered-float Mar 16, 2025
@sile sile changed the title Remove thiserror and ordered-float Remove thiserror and ordered-float crates Mar 16, 2025
@sile sile merged commit 9279b59 into master Mar 16, 2025
18 checks passed
@sile sile deleted the remove-thiserror branch March 16, 2025 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant