Conversation
There was a problem hiding this comment.
Pull Request Overview
Updates atom encoding to use the UTF-8 atom encoding tags (SMALL_ATOM_UTF8_EXT and ATOM_UTF8_EXT) instead of the deprecated ASCII-only atom encoding tag (ATOM_EXT). This ensures proper handling of non-ASCII characters in atom names and follows current Erlang Term Format conventions.
- Changes atom encoding logic to use length-based encoding selection instead of ASCII detection
- Updates all test assertions to reflect the new encoding format
- Updates documentation examples to use the new encoding
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/codec.rs | Core encoding logic updated to use UTF-8 atom encoding based on length |
| tests/lib.rs | Test assertions updated to match new encoding format |
| src/lib.rs | Documentation examples updated to reflect new encoding |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #13