Open
Conversation
c2c6c2e to
6190fa2
Compare
Owner
|
Your PR is targeting the wrong branch. See I don't use meson, so I probably wouldn't maintain any build configuration for it, but it could go in a More importantly, see the comment here about the general status of this project. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Decided to address #60 since the Makefile is very simple and easy to "translate".
This is how the process looks like:
Tried also with Muon and it builds just fine: https://github.com/rizinorg/rizin/actions/runs/13818011053/job/38656707916
This change also allows using Theft as Meson dependency. Just create
subprojects/theft.wrapwith following contents:(repository path and revision could be changed if this get merged)
and then add a dependency in any Meson project: