This repository was archived by the owner on Nov 28, 2018. It is now read-only.
session_key...#14
Open
Langmans wants to merge 6 commits into
Open
Conversation
Owner
|
Looks like the build failed because you are missing a semi-colon on line 196. Fix this and I will merge this in. Also can you send this to develop branch as develop branch is more up to date than master. I will start working on this library again soon and merge develop into master. |
Author
|
Seems the tests needs to be updated too.. No idea how to do that tho. |
Owner
|
I will have a look at the test and sort it. Leave this open for now and I will fix test and merge in soon. Thanks for your contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.