-
-
Notifications
You must be signed in to change notification settings - Fork 10
Add database collection to track semantic domain sense counts per project #4065
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the Comment |
|
- Add ProjectSemanticDomainCount model to track sense counts per domain per project - Add ISemanticDomainCountRepository interface and SemanticDomainCountRepository implementation - Add ISemanticDomainCountService interface and SemanticDomainCountService implementation - Integrate count updates into WordService for create, update, delete, and restore operations - Register new services in Startup.cs for dependency injection - Add unit tests for SemanticDomainCountService - Update all existing tests to inject the new SemanticDomainCountService dependency - Add migration method to populate counts from existing Frontier data Co-authored-by: imnasnainaec <6411521+imnasnainaec@users.noreply.github.com>
- Update LiftService to accept ISemanticDomainCountService dependency - Update LiftMerger to accept and use ISemanticDomainCountService - Update SaveImportEntries to call UpdateCountsForWords after creating words - Update test files to provide SemanticDomainCountService to LiftService Co-authored-by: imnasnainaec <6411521+imnasnainaec@users.noreply.github.com>
Done in commits 2ea49c0 and 7220b09:
|
imnasnainaec
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
… logic - Add private GetDomainCounts method to extract domain counts from words - Refactor all methods in SemanticDomainCountService to use GetDomainCounts - Add UpdateCountsForWordDeletion method to simplify deletion operations - Update WordService.Delete to use UpdateCountsForWordDeletion instead of UpdateCountsAfterWordUpdate - Revert WordService.Delete to use Create instead of Add for consistency - Add test for UpdateCountsForWordDeletion method Co-authored-by: imnasnainaec <6411521+imnasnainaec@users.noreply.github.com>
|
commit 2ea49c05dd: |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #4065 +/- ##
==========================================
+ Coverage 74.56% 74.68% +0.11%
==========================================
Files 295 297 +2
Lines 10933 11020 +87
Branches 1371 1379 +8
==========================================
+ Hits 8152 8230 +78
- Misses 2385 2393 +8
- Partials 396 397 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This comment was marked as resolved.
This comment was marked as resolved.
|
TODO: Update counts in this |
|
Wait on #4095 |
Implementation Complete
ProjectSemanticDomainCountwith projectId, domainId, and count fieldsISemanticDomainCountRepositoryinterface with CRUD operationsSemanticDomainCountRepositoryfor database operationsISemanticDomainCountServiceinterface for business logicSemanticDomainCountServiceto handle count updatesWordService.Create()to increment counts after words are addedWordService.Update()to adjust counts after words are modifiedWordService.Delete()andDeleteFrontierWord()to decrement counts after words are deletedWordService.RestoreFrontierWords()to increment counts when words are restoredOriginal prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.
This change is