Update frontend dev deps and eslint config #4070
Conversation
Bumps the frontend-dev-minor-deps group with 10 updates: | Package | From | To | | --- | --- | --- | | [@parcel/packager-raw-url](https://github.com/parcel-bundler/parcel) | `2.16.0` | `2.16.3` | | [@parcel/reporter-bundle-analyzer](https://github.com/parcel-bundler/parcel) | `2.16.0` | `2.16.3` | | [@parcel/transformer-webmanifest](https://github.com/parcel-bundler/parcel) | `2.16.0` | `2.16.3` | | [@testing-library/react](https://github.com/testing-library/react-testing-library) | `16.3.0` | `16.3.1` | | [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) | `22.18.13` | `22.19.3` | | [fs-extra](https://github.com/jprichardson/node-fs-extra) | `11.3.2` | `11.3.3` | | [globals](https://github.com/sindresorhus/globals) | `16.4.0` | `16.5.0` | | [parcel](https://github.com/parcel-bundler/parcel) | `2.16.0` | `2.16.3` | | [prettier](https://github.com/prettier/prettier) | `3.6.2` | `3.7.4` | | [typescript-eslint](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/typescript-eslint) | `8.46.3` | `8.51.0` | Updates `@parcel/packager-raw-url` from 2.16.0 to 2.16.3 - [Release notes](https://github.com/parcel-bundler/parcel/releases) - [Changelog](https://github.com/parcel-bundler/parcel/blob/v2/CHANGELOG.md) - [Commits](https://github.com/parcel-bundler/parcel/commits) Updates `@parcel/reporter-bundle-analyzer` from 2.16.0 to 2.16.3 - [Release notes](https://github.com/parcel-bundler/parcel/releases) - [Changelog](https://github.com/parcel-bundler/parcel/blob/v2/CHANGELOG.md) - [Commits](https://github.com/parcel-bundler/parcel/commits) Updates `@parcel/transformer-webmanifest` from 2.16.0 to 2.16.3 - [Release notes](https://github.com/parcel-bundler/parcel/releases) - [Changelog](https://github.com/parcel-bundler/parcel/blob/v2/CHANGELOG.md) - [Commits](https://github.com/parcel-bundler/parcel/commits) Updates `@testing-library/react` from 16.3.0 to 16.3.1 - [Release notes](https://github.com/testing-library/react-testing-library/releases) - [Changelog](https://github.com/testing-library/react-testing-library/blob/main/CHANGELOG.md) - [Commits](testing-library/react-testing-library@v16.3.0...v16.3.1) Updates `@types/node` from 22.18.13 to 22.19.3 - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node) Updates `fs-extra` from 11.3.2 to 11.3.3 - [Changelog](https://github.com/jprichardson/node-fs-extra/blob/master/CHANGELOG.md) - [Commits](jprichardson/node-fs-extra@11.3.2...11.3.3) Updates `globals` from 16.4.0 to 16.5.0 - [Release notes](https://github.com/sindresorhus/globals/releases) - [Commits](sindresorhus/globals@v16.4.0...v16.5.0) Updates `parcel` from 2.16.0 to 2.16.3 - [Release notes](https://github.com/parcel-bundler/parcel/releases) - [Changelog](https://github.com/parcel-bundler/parcel/blob/v2/CHANGELOG.md) - [Commits](https://github.com/parcel-bundler/parcel/commits) Updates `prettier` from 3.6.2 to 3.7.4 - [Release notes](https://github.com/prettier/prettier/releases) - [Changelog](https://github.com/prettier/prettier/blob/main/CHANGELOG.md) - [Commits](prettier/prettier@3.6.2...3.7.4) Updates `typescript-eslint` from 8.46.3 to 8.51.0 - [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases) - [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/typescript-eslint/CHANGELOG.md) - [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v8.51.0/packages/typescript-eslint) --- updated-dependencies: - dependency-name: "@parcel/packager-raw-url" dependency-version: 2.16.3 dependency-type: direct:development update-type: version-update:semver-patch dependency-group: frontend-dev-minor-deps - dependency-name: "@parcel/reporter-bundle-analyzer" dependency-version: 2.16.3 dependency-type: direct:development update-type: version-update:semver-patch dependency-group: frontend-dev-minor-deps - dependency-name: "@parcel/transformer-webmanifest" dependency-version: 2.16.3 dependency-type: direct:development update-type: version-update:semver-patch dependency-group: frontend-dev-minor-deps - dependency-name: "@testing-library/react" dependency-version: 16.3.1 dependency-type: direct:development update-type: version-update:semver-patch dependency-group: frontend-dev-minor-deps - dependency-name: "@types/node" dependency-version: 22.19.3 dependency-type: direct:development update-type: version-update:semver-minor dependency-group: frontend-dev-minor-deps - dependency-name: fs-extra dependency-version: 11.3.3 dependency-type: direct:development update-type: version-update:semver-patch dependency-group: frontend-dev-minor-deps - dependency-name: globals dependency-version: 16.5.0 dependency-type: direct:development update-type: version-update:semver-minor dependency-group: frontend-dev-minor-deps - dependency-name: parcel dependency-version: 2.16.3 dependency-type: direct:development update-type: version-update:semver-patch dependency-group: frontend-dev-minor-deps - dependency-name: prettier dependency-version: 3.7.4 dependency-type: direct:development update-type: version-update:semver-minor dependency-group: frontend-dev-minor-deps - dependency-name: typescript-eslint dependency-version: 8.51.0 dependency-type: direct:development update-type: version-update:semver-minor dependency-group: frontend-dev-minor-deps ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
bot
added
dependencies
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the 📝 WalkthroughWalkthroughESLint config export switched to Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
Comment |
|
commit 0e03463216: |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4070 +/- ##
=======================================
Coverage 74.57% 74.57%
=======================================
Files 295 295
Lines 10938 10938
Branches 1372 1372
=======================================
Hits 8157 8157
Misses 2385 2385
Partials 396 396
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Bumps [eslint-plugin-react-hooks](https://github.com/facebook/react/tree/HEAD/packages/eslint-plugin-react-hooks) from 5.2.0 to 7.0.1. - [Release notes](https://github.com/facebook/react/releases) - [Changelog](https://github.com/facebook/react/blob/main/packages/eslint-plugin-react-hooks/CHANGELOG.md) - [Commits](https://github.com/facebook/react/commits/HEAD/packages/eslint-plugin-react-hooks) --- updated-dependencies: - dependency-name: eslint-plugin-react-hooks dependency-version: 7.0.1 dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
There was a problem hiding this comment.
Pull request overview
This PR bumps 10 frontend development dependencies to newer minor versions, including Parcel (2.16.0 → 2.16.3), Prettier (3.6.2 → 3.7.4), and typescript-eslint (8.46.3 → 8.51.0). The changes include automatic code reformatting and ESLint configuration updates.
Key changes:
- Updated 10 npm packages to latest minor versions
- Prettier reformatted several API files for improved readability
- Modified ESLint configuration structure (appears incompatible with updates)
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| package.json | Updated 10 devDependencies to newer minor versions |
| package-lock.json | Synchronized lockfile with package.json updates, including transitive dependencies |
| src/api/api/*.ts | Prettier reformatted FormData initialization for better readability |
| eslint.config.mjs | Updated ESLint config structure with breaking changes |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
eslint.config.mjs (1)
48-60: TypeScript rules apply to all files including JavaScript without proper scoping.The TypeScript parser (line 15) and TypeScript-specific rules (lines 48–60) are configured globally without the
files: ["**/*.ts", "**/*.tsx"]pattern. This means TypeScript-scoped rules will be enforced on JavaScript files (.js) in the project, which violates ESLint flat config best practices and will cause linting failures on the 4 existing JavaScript files insrc/.Rules like
@typescript-eslint/explicit-function-return-typerequire type annotations that JavaScript files don't have. Add file scoping to isolate TypeScript configuration to TypeScript files only:Recommended fix
- ...typescriptEslint.configs.strict, - { + { + files: ["**/*.ts", "**/*.tsx"], + ...typescriptEslint.configs.strict, rules: { "@typescript-eslint/explicit-function-return-type": [ "warn", { allowExpressions: true }, ], "@typescript-eslint/no-dynamic-delete": "off", "@typescript-eslint/no-explicit-any": "off", "@typescript-eslint/no-inferrable-types": "warn", "@typescript-eslint/no-non-null-assertion": "off", }, },Also add
filesscoping to the global config block (lines 12–47) to apply the TypeScript parser only to TypeScript files.
📜 Review details
Configuration used: defaults
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (6)
eslint.config.mjspackage.jsonsrc/api/api/audio-api.tssrc/api/api/avatar-api.tssrc/api/api/lift-api.tssrc/api/api/speaker-api.ts
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
- GitHub Check: upload_coverage
- GitHub Check: Analyze (csharp)
- GitHub Check: test_coverage (22)
- GitHub Check: docker_build
🔇 Additional comments (9)
src/api/api/speaker-api.ts (1)
485-488: LGTM! Formatting change in auto-generated code.The FormData instantiation has been reformatted across multiple lines, but the logic remains identical. Since this file is auto-generated by OpenAPI Generator, these formatting changes are expected and should not be manually modified.
src/api/api/audio-api.ts (1)
191-194: LGTM! Consistent formatting changes in auto-generated code.The FormData instantiation formatting has been updated in both upload methods. The logic remains unchanged, and these are expected updates from the OpenAPI Generator.
Also applies to: 258-261
src/api/api/avatar-api.ts (1)
124-127: LGTM! Formatting change in auto-generated code.The FormData instantiation formatting is consistent with the changes in other API files. No behavioral changes.
src/api/api/lift-api.ts (1)
356-359: LGTM! Consistent formatting changes in auto-generated code.The FormData instantiation formatting has been updated in both upload methods. The logic remains unchanged, consistent with updates across all API files.
Also applies to: 419-422
package.json (2)
91-93: LGTM! Development dependency updates look good.The dependency updates are appropriate:
- Parcel ecosystem updates (2.16.0 → 2.16.3) are patch releases
- Prettier update (3.6.2 → 3.7.4) explains the FormData formatting changes in the API files
- TypeScript ESLint update (8.46.3 → 8.51.0) and other updates are minor/patch versions
- Type declaration updates enhance development experience
The formatting changes observed in the API files align with the Prettier version update.
Also applies to: 95-95, 101-101, 122-123, 131-131, 134-134, 140-140
120-120: Verify eslint-plugin-react-hooks 7.0.1 configuration and runtime behavior.The major version update (5.2.0 → 7.0.1) introduces several breaking changes:
- Flat config format is now the default (legacy config moved to
recommended-legacy)- New compiler rule (
react-hooks/react-compiler) added from merged eslint-plugin-react-compiler- Node.js 18+ required (minimum version bump)
- Known 7.0.1 runtime issues reported with ESM resolution in some environments
The PR's ESLint config update suggests the flat config transition has been handled. Confirm that:
- The new
react-hooks/react-compilerrule is properly configured or disabled if not needed- No ESM/runtime issues occur in your build environment with 7.0.1
- The ESLint configuration explicitly uses the correct config format (flat vs. legacy)
eslint.config.mjs (3)
8-8: Good practice: usingdefineConfigfor type safety.Wrapping the configuration with
defineConfigprovides better TypeScript type checking for the ESLint configuration, which helps catch configuration errors at development time.(Approval is contingent on resolving the import path issue flagged in Line 1.)
Also applies to: 61-61
51-53: Good refinement:allowExpressionsoption improves developer experience.Adding
{ allowExpressions: true }to the explicit function return type rule is a sensible refinement. This allows arrow functions used as expressions (e.g., callbacks, array methods) to omit explicit return types when the type can be inferred, reducing verbosity while maintaining type safety.
10-10: No action needed. Thedic.jsignore pattern was appropriately removed; this file does not exist in the repository.
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 6 out of 8 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
imnasnainaec
changed the title
imnasnainaec
left a comment
imnasnainaec
left a comment
There was a problem hiding this comment.
@imnasnainaec reviewed 8 files and all commit messages, and resolved 2 discussions.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @dependabot[bot]).
jasonleenaylor
left a comment
jasonleenaylor
left a comment
There was a problem hiding this comment.
@jasonleenaylor reviewed 8 files and all commit messages, and made 1 comment.
Reviewable status:
imnasnainaec
deleted the
dependabot/npm_and_yarn/frontend-dev-minor-deps-f58d45d7dd
branch
Bumps the frontend-dev-minor-deps group with 10 updates:
2.16.02.16.32.16.02.16.32.16.02.16.316.3.016.3.122.18.1322.19.311.3.211.3.316.4.016.5.02.16.02.16.33.6.23.7.48.46.38.51.0Also bumps eslint-plugin-react-hooks from 5.2.0 to 7.0.1.
Changelog
Sourced from eslint-plugin-react-hooks's changelog.
Commits
Also updates the eslint config.
Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore <dependency name> major versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)@dependabot ignore <dependency name> minor versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)@dependabot ignore <dependency name>will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)@dependabot unignore <dependency name>will remove all of the ignore conditions of the specified dependency@dependabot unignore <dependency name> <ignore condition>will remove the ignore condition of the specified dependency and ignore conditionsThis change is
Summary by CodeRabbit
Chores
Refactor
Style
Documentation
✏️ Tip: You can customize this high-level summary in your review settings.