Skip to content

Conversation

@jasonleenaylor
Copy link
Contributor

@jasonleenaylor jasonleenaylor commented Dec 15, 2025

  • Make copilot assisted commits add a changelog entry
  • Enable developers to ask copilot to update the changelog for them

This change is Reviewable

* Make copilot assisted commits add a changelog entry
* Enable developers to ask copilot to update the changelog
  for them
@github-actions
Copy link

github-actions bot commented Dec 15, 2025

Palaso Tests

     4 files  ±0       4 suites  ±0   10m 47s ⏱️ -2s
 5 092 tests ±0   4 858 ✅  - 1  234 💤 +1  0 ❌ ±0 
16 591 runs  ±0  15 869 ✅  - 2  722 💤 +2  0 ❌ ±0 

Results for commit 9c35eee. ± Comparison against base commit d010103.

This pull request skips 1 test.
SIL.Tests.IO.FileLocationUtilitiesTests ‑ LocateInProgramFiles_SendValidProgramDeepSearch_ReturnsProgramPath

♻️ This comment has been updated with latest results.

Copy link
Contributor

@tombogle tombogle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tombogle reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @jasonleenaylor)


.github/copilot-instructions.md line 18 at r1 (raw file):

- **Update the Changelog:** If the suggested code changes functionality, fixes a bug, or adds a feature, you **must** generate an update for `CHANGELOG.md`.
    - Look for the `## [Unreleased]` section at the top of the changelog.
    - Insert a bullet point under the appropriate subsection: `### Added`, `### Changed`, or `### Fixed`.

What about the less-common:

Deprecated

Removed

Security

? Maybe we don't anticipate Copilot doing those kinds of things?

Copy link
Contributor

@imnasnainaec imnasnainaec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@imnasnainaec reviewed all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @jasonleenaylor)


.github/copilot-instructions.md line 19 at r1 (raw file):

    - Look for the `## [Unreleased]` section at the top of the changelog.
    - Insert a bullet point under the appropriate subsection: `### Added`, `### Changed`, or `### Fixed`.
    - If the subsections do not exist under `[Unreleased]`, create them.

New subsections should be created according to the order given in the CHANGELOG comment

<!-- Available types of changes:
### Added
### Fixed
### Changed
### Deprecated
### Removed
### Security
-->

@hatton
Copy link
Member

hatton commented Dec 15, 2025

@jasonleenaylor we should do a brand-agnostic AGENTS.md instead, along with "chat.useAgentsMdFile": true in workspace's .vscode/settings.json

Copy link
Contributor Author

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Reviewable status: 0 of 2 files reviewed, all discussions resolved (waiting on @imnasnainaec and @tombogle)

@jasonleenaylor jasonleenaylor enabled auto-merge (squash) December 16, 2025 00:46
@jasonleenaylor jasonleenaylor merged commit b51a326 into master Dec 16, 2025
9 of 10 checks passed
@jasonleenaylor jasonleenaylor deleted the feature/addCopilotInstructions branch December 16, 2025 00:52
- `### Security` - for security-related fixes or improvements
- If the subsections do not exist under `[Unreleased]`, create them as needed.
- Format: `- **[Scope]** Description of the change.` (where Scope is the affected library/namespace)
- For breaking changes, prefix with `BREAKING CHANGE:` in the description.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be enhanced so that it also adds +semver:major to the commit message for breaking changes and +semver:minor for added functionality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants