Skip to content

fix: self-assignment no-ops and mutable default argument in usfmerge.py #1158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
megahirt wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: self-assignment no-ops and mutable default argument in usfmerge.py #1158

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions python/lib/ptxprint/usfmerge.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -585,8 +585,8 @@ def reorder(self):
if bi is None:
bi=i-1
logger.log(7, f"Merge.5b: {self.acc[bi].position} , {self.acc[i].position}?")
self.acc[i].verse = self.acc[i].verse
self.acc[i].pnum = self.acc[i].pnum
self.acc[i].verse = self.acc[bi].verse
self.acc[i].pnum = self.acc[bi].pnum
self.acc[i].insert(0,self.acc[bi][0])
#self.acc[bi].syncp = self.acc[i].syncp
#self.acc[bi].type = ChunkType.USERSYNC
Expand Down Expand Up @@ -651,7 +651,9 @@ def reorder(self):
else:
logger.log(7, f"r: {i}, '-//-', {self.acc[i].type=}, {self.acc[i]=}")

def score(self,results={}):
def score(self, results=None):
if results is None:
results = {}
"""Calculate the scores for each chunk, returning an array of non-zero scores (potential break points)
If the results parameter is given, then the return value is a summation
"""
Expand Down