Draft
Fix Nota142 AES67 audio: add a=sendonly to SDP, fix SAP messageID churn#6
Conversation
Agent-Logs-Url: https://github.com/silly82/go-radio-streamer/sessions/7cf33956-1fb8-4330-972e-42fe3d83be82 Co-authored-by: silly82 <527175+silly82@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add audio stream to Nota142 adapter
Fix Nota142 AES67 audio: add a=sendonly to SDP, fix SAP messageID churn
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Nota142 (and compatible AES67 hardware receivers) were not discovering the stream via SAP and produced no audio even when the SDP was added manually.
Changes
pkg/aes67/sdp.go— Adda=sendonlyAES67 hardware receivers use the media direction attribute to gate audio decoding. Without it the stream appears in the UI but is silent. Placed between
a=ptimeanda=ts-refclkper common AES67 SDP convention:pkg/aes67/sap.go— RemovemessageID++fromsend()RFC 2974 requires all periodic re-announcements of the same session to carry the same message ID. Incrementing it on every 30 s tick made each announcement look like a new session to SAP listeners, preventing stable stream discovery. The ID is now fixed for the session lifetime (randomly seeded at construction, as before).
pkg/aes67/sdp_test.go—TestBuildSDP_Defaultsextended to asserta=sendonlyis present.Original prompt
Created from VS Code.