HTML5 <meta charset="utf-8">

[lerni]

Description

Addition to silverstripe/silverstripe-framework#11479

Issues

silverstripe/silverstripe-framework#7438

Pull request checklist

• The target branch is correct
  • See picking the right version
• All commits are relevant to the purpose of the PR (e.g. no debug statements, unrelated refactoring, or arbitrary linting)
  • Small amounts of additional linting are usually okay, but if it makes it hard to concentrate on the relevant changes, ask for the unrelated changes to be reverted, and submitted as a separate PR.
• The commit messages follow our commit message guidelines
• The PR follows our contribution guidelines
• Code changes follow our coding conventions
• This change is covered with tests (or tests aren't necessary for this change)
• Any relevant User Help/Developer documentation is updated; for impactful changes, information is added to the changelog for the intended release
• CI is green

[GuySartorelli]

Sorry it's taken so long to review this. I've just retargeted it to 6.0 and rebased. Hopefully CI goes green.

[GuySartorelli]

@lerni Looking at the issue, it's not clear if there even is a problem - @Blueace mentions "a warning" but it's not clear where the warning is - I can't see any warning in the dev console in a fresh installation of Silverstripe CMS 6...

Can you please help me understand what the problem actually is and how I can verify it?

[Blueace]

The warning was on the W3C validator.

[lerni]

• first error validating ss.org W3C Validator
• Document Metadata
• Charset Specification
• Anatomy of an HTML Document

However, the failing tests are legitimate and require adaptation. I’ve already made some adjustments, but I don’t recall the exact details. AFAIR how DOMDocument handles the HTML5 doctype. I’ll give it another try - hope to find some time soon.