FIX Update phpunit.xml.dist#11547
Open
lekoala wants to merge 1 commit into
Open
Conversation
GuySartorelli
requested changes
Jan 15, 2025
Comment on lines
-13
to
+20
| <directory>tests/php</directory> | ||
| <exclude> | ||
| <directory>tests/php/ORM</directory> | ||
| </exclude> | ||
| <directory>tests/php/Control</directory> | ||
| <directory>tests/php/Core</directory> | ||
| <directory>tests/php/Dev</directory> | ||
| <directory>tests/php/Forms</directory> | ||
| <directory>tests/php/i18n</directory> | ||
| <directory>tests/php/Logging</directory> | ||
| <directory>tests/php/Security</directory> | ||
| <directory>tests/php/View</directory> |
Member
There was a problem hiding this comment.
Explicitly listing each item isn't maintainable - we will innevitably forget to add new directories here when we create them.
Contributor
Author
There was a problem hiding this comment.
then the other way is to move test files into one folder per test suite that can run in parallel
using "exclude" is not really maintainable either since it's deprecated
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Running tests currently give warnings. This seems fairly easy to fix so I did it :-)
Manual testing steps
No more warnings when running tests
Issues
#11546
Pull request checklist