FEAT Phpunit - update i18n suite for windows / phpunit 10 compatibility#11548
Open
lekoala wants to merge 3 commits into
Open
FEAT Phpunit - update i18n suite for windows / phpunit 10 compatibility#11548lekoala wants to merge 3 commits into
lekoala wants to merge 3 commits into
Conversation
Member
|
The linked issue doesn't seem related. |
Contributor
Author
|
@GuySartorelli i know, i can create one or two separate issues if needed basically the issue are:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I tried to run the test suite without warnings on my local machine. Phpunit 9 complains about Phpunit 10 deprecation. I found a nice way around that could be migrated to SapphireTest for other test suites.
I've also made some changes to be able to run this on windows. This should not affect linux/mac os.
Manual testing steps
Run the 18n test suite
See that you get no phpunit 10 deprecation
See that all works well on windows
Issues
#11525 (i'm creating the test for this, and it's easier to work with a test suite that is not making warnings :) )
Pull request checklist