Fix SS_List import for CMS 6 namespace move - #1
Merged
Merged
Conversation
- AtomFeedTest: ArrayList moved to SilverStripe\Model\List - PasswordStrengthTest + security.yml: PasswordValidator moved to Security\Validation and split; bind the rules-based RulesPasswordValidator so the NZISM policy is preserved (CMS 6 now defaults to EntropyPasswordValidator) - Remove orphaned PBKDF2Test (encryptor source removed in 17c55c5)
pjayme
changed the title
This reverts commit dd441eb.
pjayme
changed the title
edwilde
approved these changes
Jul 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Instantiating
CwpAtomFeedon CMS 6 throws:In CMS 6 the
SS_Listinterface moved fromSilverStripe\ORM\SS_ListtoSilverStripe\Model\List\SS_List. The oldSilverStripe\ORM\SS_Listno longer exists, so the$entriestype hint inCwpAtomFeed::__construct()resolves to a missing interface.DataListnow implements the new interface, so it never satisfies the stale hint and every construction fails with theTypeErrorabove.Fix
Import
SS_ListfromSilverStripe\Model\List— the interfaceDataListactually implements, and the same one the parentRSSFeed::__construct()already type-hints.Verification
SilverStripe\ORM\SS_Listconfirmed absent in framework 6;SilverStripe\Model\List\SS_Listpresent and implemented byDataList.RSSFeed::__construct()already type-hintsSilverStripe\Model\List\SS_List, so the argument now passes through consistently.php -lclean; imports remain alphabetically ordered (PSR2).