Skip to content
This repository was archived by the owner on Sep 27, 2022. It is now read-only.

WIP: New HomeScreen and App's navigation#253

Open
aarrtthhuurr wants to merge 19 commits into
developfrom
feature/improve-home-ui
Open

WIP: New HomeScreen and App's navigation#253
aarrtthhuurr wants to merge 19 commits into
developfrom
feature/improve-home-ui

Conversation

@aarrtthhuurr
Copy link
Copy Markdown
Contributor

image

(J'aime le cidre)

@aarrtthhuurr aarrtthhuurr changed the title New HomeScreen and App's navigation WIP: New HomeScreen and App's navigation Nov 21, 2019
Copy link
Copy Markdown
Contributor

@NastuzziSamy NastuzziSamy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice redesign but: (for history and stats)

78122592_615976345812915_8260340627066060800_n

Comment thread src/components/History/Transaction.js Outdated
import { beautifyDate, beautifyDateTime } from '../../utils/date';

if (Platform.OS === 'android' && UIManager.setLayoutAnimationEnabledExperimental) {
UIManager.setLayoutAnimationEnabledExperimental(true);
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You cannot define a component setting in a sub file. Do it directly in the main app file pls

Comment thread src/components/History/Transaction.js Outdated
}

export default class Transaction extends Component {
getTransactionIcon = type => {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be static but ok

Comment thread src/components/History/Transaction.js Outdated
}
};

getTransactionColor = type => {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be static but ok

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants