-
Notifications
You must be signed in to change notification settings - Fork 0
add local EdgeScan setup instructions and prerequisites #340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
SevenThomas
wants to merge
7
commits into
main
Choose a base branch
from
SevenThomas/issue339
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+144
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chore(knip): update ignoreBinaries to include 'container' feat(package): add edgescan:agent script for local security scans
Contributor
Reviewer's GuideAdds local EdgeScan security scanning support and documentation, including prerequisites for macOS containerization, API token and asset ID configuration, plus new npm scripts for CI/agent and local dev scans. Sequence diagram for EdgeScan scans in dev and CIsequenceDiagram
actor Developer
participant DevShell as Dev_shell
participant CI as CI_pipeline
participant Npm as pnpm_scripts
participant Container as Container_runtime
participant Image as edgescan_image
participant EdgeScan as EdgeScan_API
Developer->>DevShell: export ES_API_TOKEN
Developer->>DevShell: export ES_ASSET_ID
Developer->>Npm: pnpm run edgescan:dev
Npm->>Container: start container run
Container->>Image: launch edgescan/cicd-integration:latest
Image->>EdgeScan: authenticate with ES_API_TOKEN
Image->>EdgeScan: start scan for ES_ASSET_ID
EdgeScan-->>Image: scan results
Image-->>Developer: print results in terminal
CI->>Npm: pnpm run edgescan:agent
Npm->>Container: docker run edgescan/cicd-integration:latest
Container->>Image: launch image
Image->>EdgeScan: authenticate with ES_API_TOKEN
Image->>EdgeScan: start scan for ES_ASSET_ID
EdgeScan-->>Image: scan results
Image-->>CI: return status for pipeline
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey - I've left some high level feedback:
- In
intro.md, the fenced code block closing marker was changed fromtoi, which will break markdown rendering and should be reverted to a plain triple backtick. - The new EdgeScan scripts and setup instructions are tightly coupled to macOS Apple Native Containers and bash-style environment variables; consider clarifying or guarding these for non-macOS/non-bash environments (e.g., documenting alternatives or adding OS checks in the scripts).
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- In `intro.md`, the fenced code block closing marker was changed from ``` to ```i, which will break markdown rendering and should be reverted to a plain triple backtick.
- The new EdgeScan scripts and setup instructions are tightly coupled to macOS Apple Native Containers and bash-style environment variables; consider clarifying or guarding these for non-macOS/non-bash environments (e.g., documenting alternatives or adding OS checks in the scripts).Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
Document local EdgeScan usage and wire it into project scripts for development and automation.
New Features:
Documentation: