Skip to content

fix(dna): K11 shared-match owner selection and FK trust#20

Merged
simonellefsen merged 2 commits into
mainfrom
fix/k11-shared-match-owner-selection
Jul 5, 2026
Merged

fix(dna): K11 shared-match owner selection and FK trust#20
simonellefsen merged 2 commits into
mainfrom
fix/k11-shared-match-owner-selection

Conversation

@simonellefsen

@simonellefsen simonellefsen commented Jul 5, 2026

Copy link
Copy Markdown
Owner

Summary

  • Require kit-owner confirmation when importing shared-segment CSVs (SharedSegmentImportModal), with optional counterpart link and married-name alias.
  • Trust dna_tests.person_id at load time before fuzzy CSV name matching so imports no longer vanish when kit names differ from tree names (e.g. Helle Due vs Helle Andersen).
  • Show unlinked counterparts in the shared autosomal match list instead of dropping them; add admin re-link owner repair for orphan imports.
  • Match load-time name resolution against maiden names and metadata.alternateNames (lib/dnaPersonNameVariants.ts).
  • Batch shared CSV import: pick multiple files, confirm kit owner once (DNATab + SharedSegmentImportModal).
  • Inline link / create match person / dismiss on unlinked rows in the admin match list (lib/dnaUnlinkedMatchAdapter.ts).

Test plan

  • Import a shared-segment CSV on a profile — confirm kit-owner modal appears and saves owner + optional counterpart.
  • Import multiple shared CSVs via Import multiple CSVs — one owner confirmation applies to all files.
  • On admin DNA panel for kit owner, verify all imported matches appear (linked and unlinked).
  • On an unlinked row in the main match list, use Link / Create match person / Not in my tree inline actions.
  • For existing orphan imports, use Set kit owner to selected person in K3 and confirm matches move to the unified list.
  • npm test (446 passing on branch)

Require kit-owner confirmation on shared CSV import, trust person_id at
load time, show unlinked counterparts in the match list, and add re-link
owner repair for orphan imports.

Co-authored-by: Cursor <cursoragent@cursor.com>
@vercel

vercel Bot commented Jul 5, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
linegra Ready Ready Preview, Comment Jul 5, 2026 7:47pm

Complete shared-match fixes so married-name variants resolve at load,
multiple CSVs share one kit owner, and unlinked rows can be linked inline.

Co-authored-by: Cursor <cursoragent@cursor.com>
@simonellefsen
simonellefsen marked this pull request as ready for review July 5, 2026 19:48
@simonellefsen
simonellefsen merged commit 5bc5b0a into main Jul 5, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant