Open
Conversation
simonrob
reviewed
Mar 10, 2026
| _LOGGER = None | ||
| _HANDLER = None | ||
| _DATE_FORMAT = '%Y-%m-%d %H:%M:%S:' | ||
| _SYSLOG_MESSAGE_FORMAT = '%s: %%(message)s' % APP_NAME |
Owner
There was a problem hiding this comment.
Changing the name makes sense, but why do we need to remove the : too?
Author
There was a problem hiding this comment.
this woould make the : part of the syslog identifier, which is not desirable IMO
Owner
There was a problem hiding this comment.
Thinking about this further, would it be better to remove _SYSLOG_MESSAGE_FORMAT entirely, and just use APP_SHORT_NAME when setting up the logger? That would fall back to the logger's standard format, which is likely to be more widely expected/supported.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My fix for #411