add support for fvm#1
Open
BacLuc wants to merge 1 commit into
Open
Conversation
fvm uses an version which is explicitly set. This makes it easier for e.g. branch switching. Then you don't have to do submodule shenanigans. You can install fvm like this on linux and in windows with wsl: https://github.com/BacLuc/provision-machines/blob/06440bb1590d8332d603c9b0debbbf4be2879f5a/roles/basic_utils/tasks/main.yml#L320,L397
Owner
|
Thanks for your contribution and the bug report 🙈 The submodule is indeed quite annoying. I'll have a look at fvm. |
Contributor
Author
|
Thanks for fixing the bug right away. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fvm uses an version which is explicitly set.
This makes it easier for e.g. branch switching. Then you don't have to do submodule shenanigans. You can install fvm like this on linux and in windows with wsl:
https://github.com/BacLuc/provision-machines/blob/06440bb1590d8332d603c9b0debbbf4be2879f5a/roles/basic_utils/tasks/main.yml#L320,L397
My goal is to move the summaries up a little if the user has set android to display the bottom controls:
Not necessary to accept this into your repo. I personally liked fvm better.