Repository navigation
fix: Remap /bin/bash to /bin/sh - #15
Open
coastalwhite wants to merge 1 commit into
Open
coastalwhite wants to merge 1 commit into
coastalwhite wants to merge 1 commit into
Conversation
Not all Unix-based distributions have `/bin/bash` (notably NixOS). This remaps it to the more standard `/bin/sh`.
|
Thanks for your contribution! We require contributors to sign our Contributor License Agreement, and we don"t have you on file. In order for us to review and merge your code, please follow the instructions on our website. |
Contributor
|
Hi! Our scripts are not posix-compliant, so they won't work with a shell which doesn't have bash features (see crash in CI for one example). We're open to making these scripts posix-compliant, if it doesn't complicate them. Some refactoring could make this easier, e.g., explicitly using |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not all Unix-based distributions have
/bin/bash(notably NixOS). This remaps it to the more standard/bin/sh.