Skip to content

fix jc_suspend_compression usage #837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Hamdy-khader wants to merge 1 commit into
base: R25.10-Hotfix
Choose a base branch
from
Open

fix jc_suspend_compression usage #837

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions simplyblock_core/cluster_ops.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -651,6 +651,14 @@ def cluster_activate(cl_id, force=False, force_lvstore_create=False) -> None:
if not ret:
logger.info("Failed to resume JC compression adding task...")
tasks_controller.add_jc_comp_resume_task(node.cluster_id, node.get_id(), jm_vuid=node.jm_vuid)
# start comp on node for sec stack
nodes = db_controller.get_primary_storage_nodes_by_secondary_node_id(node.get_id())
if nodes:
sec_node = nodes[0]
ret, err = node.rpc_client().jc_suspend_compression(jm_vuid=sec_node.jm_vuid, suspend=False)
if not ret:
logger.info("Failed to resume JC compression adding task...")
tasks_controller.add_jc_comp_resume_task(node.cluster_id, node.get_id(), jm_vuid=sec_node.jm_vuid)

if not cluster.cluster_max_size:
cluster = db_controller.get_cluster_by_id(cl_id)
Expand Down
12 changes: 3 additions & 9 deletions simplyblock_core/storage_node_ops.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3088,12 +3088,12 @@ def recreate_lvstore_on_sec(secondary_node):
primary_node.write_to_db()
return False

# sending to the node that is being restarted (secondary_node) with the secondary group jm_vuid (primary_node.jm_vuid)
ret, err = secondary_node.rpc_client().jc_suspend_compression(jm_vuid=primary_node.jm_vuid, suspend=False)
# sending to the node that is being restarted (secondary_node) with the secondary group jm_vuid (secondary_node.jm_vuid)
ret, err = secondary_node.rpc_client().jc_suspend_compression(jm_vuid=secondary_node.jm_vuid, suspend=False)
if not ret:
logger.info("Failed to resume JC compression adding task...")
tasks_controller.add_jc_comp_resume_task(
secondary_node.cluster_id, secondary_node.get_id(), jm_vuid=primary_node.jm_vuid)
secondary_node.cluster_id, secondary_node.get_id(), jm_vuid=secondary_node.jm_vuid)

### 2- create lvols nvmf subsystems
for lvol in lvol_list:
Expand Down Expand Up @@ -3625,12 +3625,6 @@ def create_lvstore(snode, ndcs, npcs, distr_bs, distr_chunk_bs, page_size_in_blo
logger.error(err)
return False

# sending to the other node (sec_node) with the primary group jm_vuid (snode.jm_vuid)
ret, err = sec_node.rpc_client().jc_suspend_compression(jm_vuid=snode.jm_vuid, suspend=False)
if not ret:
logger.info("Failed to resume JC compression adding task...")
tasks_controller.add_jc_comp_resume_task(sec_node.cluster_id, sec_node.get_id(), jm_vuid=snode.jm_vuid)

sec_rpc_client = sec_node.rpc_client()
sec_rpc_client.bdev_examine(snode.raid)
sec_rpc_client.bdev_wait_for_examine()
Expand Down
Loading