Skip to content

Fix sfam-2564 #838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Hamdy-khader wants to merge 1 commit into
base: R25.10-Hotfix
Choose a base branch
from
Open

Fix sfam-2564 #838

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 23 additions & 4 deletions simplyblock_core/services/tasks_runner_migration.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,10 +46,13 @@ def task_runner(task):
return False

if task.status in [JobSchedule.STATUS_NEW, JobSchedule.STATUS_SUSPENDED]:
current_online_devices = 0
for node in db.get_storage_nodes_by_cluster_id(task.cluster_id):
if node.is_secondary_node: # pass
continue

for dev in node.nvme_devices:
if dev.status == NVMeDevice.STATUS_ONLINE:
current_online_devices += 1
if node.status == StorageNode.STATUS_ONLINE and node.online_since:
try:
diff = datetime.now(timezone.utc) - datetime.fromisoformat(node.online_since)
Expand All @@ -62,6 +65,17 @@ def task_runner(task):
except Exception as e:
logger.error(f"Failed to get online since: {e}")

migration_devices = 0
if "migration_devices" in task.function_params:
migration_devices = task.function_params["migration_devices"]

if current_online_devices < migration_devices:
task.function_result = f"only {current_online_devices} devices online, waiting for more devices to be online"
task.status = JobSchedule.STATUS_SUSPENDED
task.retry += 1
task.write_to_db(db.kv_store)
return False

task.status = JobSchedule.STATUS_RUNNING
task.function_result = ""
task.write_to_db(db.kv_store)
Expand All @@ -78,6 +92,12 @@ def task_runner(task):
task.write_to_db(db.kv_store)
return True

current_online_devices = 0
for node in db.get_storage_nodes_by_cluster_id(task.cluster_id):
for dev in node.nvme_devices:
if dev.status == NVMeDevice.STATUS_ONLINE:
current_online_devices += 1

distr_name = task.function_params["distr_name"]

qos_high_priority = False
Expand All @@ -96,10 +116,9 @@ def task_runner(task):
task.retry += 1
task.write_to_db(db.kv_store)
return True
task.function_params['migration'] = {
"name": distr_name}
task.function_params['migration'] = {"name": distr_name}
task.function_params['migration_devices'] = current_online_devices
task.write_to_db(db.kv_store)
# time.sleep(1)

try:
if "migration" in task.function_params:
Expand Down
Loading