Skip to content

Restore loadable scanner modules#528

Merged
simsong merged 3 commits into
mainfrom
codex/issue-505-plugin-loader
Jul 21, 2026
Merged

Restore loadable scanner modules#528
simsong merged 3 commits into
mainfrom
codex/issue-505-plugin-loader

Conversation

@simsong-codex

Copy link
Copy Markdown
Collaborator

Codex-authored replacement for the abandoned removal approach in #523.

Restores runtime scanner loading through a versioned bulk_extractor_scanner_v1 factory, discovers scan_* modules from -P and BE_PATH, retains module handles until scanner cleanup, and documents the supported ABI. The new integration test builds a real module and verifies that -P discovery registers and enables it.

Validation:

  • bash bootstrap.sh && ./configure
  • make -C src check TESTS=test_be -j4 (pass; 68 test cases, 100456 assertions)

The broader make check also reaches the pre-existing sandbox-only machine_stats failure because this environment denies /bin/ps; it is unrelated to this change.

@simsong-codex
simsong-codex marked this pull request as ready for review July 21, 2026 01:27
@codecov

codecov Bot commented Jul 21, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 90.00000% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.29%. Comparing base (6654dd3) to head (6155b01).

Files with missing lines Patch % Lines
src/be20_api/scanner_set.cpp 83.33% 5 Missing ⚠️
src/test_be3.cpp 94.74% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #528      +/-   ##
==========================================
+ Coverage   74.18%   74.29%   +0.11%     
==========================================
  Files         115      116       +1     
  Lines       12928    12982      +54     
==========================================
+ Hits         9590     9644      +54     
  Misses       3338     3338              
Flag Coverage Δ
unittests 74.29% <90.00%> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@simsong-codex
simsong-codex force-pushed the codex/issue-505-plugin-loader branch 2 times, most recently from cc31825 to 8c656de Compare July 21, 2026 08:12

@simsong simsong left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

scanner_set.cpp still has a bunch of #if 0 constructs in it that seem to be related to this functionality. Plese review and delete as necessary. Clean up the entire file as part of this PR.

Address codecov issues.

@simsong-codex
simsong-codex force-pushed the codex/issue-505-plugin-loader branch from 8c656de to 9b24ce4 Compare July 21, 2026 09:11
@simsong-codex
simsong-codex force-pushed the codex/issue-505-plugin-loader branch from 9b24ce4 to 846f976 Compare July 21, 2026 09:19
@simsong
simsong enabled auto-merge July 21, 2026 14:44
@simsong
simsong merged commit c929c36 into main Jul 21, 2026
11 checks passed
@simsong
simsong deleted the codex/issue-505-plugin-loader branch July 21, 2026 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants