Restore loadable scanner modules#528
Merged
Merged
Conversation
simsong-codex
marked this pull request as ready for review
July 21, 2026 01:27
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #528 +/- ##
==========================================
+ Coverage 74.18% 74.29% +0.11%
==========================================
Files 115 116 +1
Lines 12928 12982 +54
==========================================
+ Hits 9590 9644 +54
Misses 3338 3338
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
simsong-codex
force-pushed
the
codex/issue-505-plugin-loader
branch
2 times, most recently
from
July 21, 2026 08:12
cc31825 to
8c656de
Compare
simsong
requested changes
Jul 21, 2026
simsong
left a comment
Owner
There was a problem hiding this comment.
scanner_set.cpp still has a bunch of #if 0 constructs in it that seem to be related to this functionality. Plese review and delete as necessary. Clean up the entire file as part of this PR.
Address codecov issues.
simsong-codex
force-pushed
the
codex/issue-505-plugin-loader
branch
from
July 21, 2026 09:11
8c656de to
9b24ce4
Compare
simsong-codex
force-pushed
the
codex/issue-505-plugin-loader
branch
from
July 21, 2026 09:19
9b24ce4 to
846f976
Compare
simsong
enabled auto-merge
July 21, 2026 14:44
simsong
approved these changes
Jul 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Codex-authored replacement for the abandoned removal approach in #523.
Restores runtime scanner loading through a versioned
bulk_extractor_scanner_v1factory, discoversscan_*modules from-PandBE_PATH, retains module handles until scanner cleanup, and documents the supported ABI. The new integration test builds a real module and verifies that-Pdiscovery registers and enables it.Validation:
bash bootstrap.sh && ./configuremake -C src check TESTS=test_be -j4(pass; 68 test cases, 100456 assertions)The broader
make checkalso reaches the pre-existing sandbox-onlymachine_statsfailure because this environment denies/bin/ps; it is unrelated to this change.