Support GPG password prompt#448
Closed
bunysae wants to merge 10 commits into
Closed
Conversation
Owner
Can you link to those pull requests? |
Owner
|
What about Yarn? Look at the task above the one you modified. |
Owner
|
Can you give the PR a better title? |
Contributor
Author
|
When using yarn, the gpg-password-prompt was also gobbled. I fixed it with the last commits. |
This was referenced Feb 17, 2020
Closed
Owner
|
Can you mention this feature in the readme? |
Contributor
Author
It's mentioned. |
Owner
|
Maybe we could move this forward by retargeting your PRs to https://github.com/cenk1cenk2/listr2 and then move to |
bunysae
added a commit
to bunysae/np
that referenced
this pull request
Jun 16, 2021
bunysae
added a commit
to bunysae/np
that referenced
this pull request
Jun 16, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #79 the gpg-password-prompt is gobbled. The listr-task "Bumping version using npm" gets a suspend-flag, which stops the listr-update-renderer.
In order to get this solution working, there are same changes necessary at listr and listr-update-renderer.
The pull-requests for this changes can be found at the following links:
Testing this pull-request requires the following client-setup:
gpg --generate-keygit config --set --global user.signingkey <KEY>npm config set sign-git-commit trueoryarn config set version-sign-git-tag trueIssueHunt Summary