Add devEngines.packageManager support#789
Merged
Merged
Conversation
devEngies.packageManager supportdevEngines.packageManager support
Owner
|
One small issue:
That means this change can silently accept an invalid manifest and then publish with a different package manager than the package actually declares. I’d rather make this error out instead of treating it as a fallback case. I think the current missing-name test should be flipped accoridngly. |
Contributor
Author
|
@sindresorhus Nice catch. I've updated the logic and tests to check the name field. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References
devEnginesfield pnpm/pnpm#8153