Add --allow-dirty flag#792
Closed
idleberg wants to merge 1 commit into
Closed
Conversation
Owner
|
Thanks for the PR. I understand the monorepo use case, but I am going to pass on this.
For this workflow, the supported path is to release from a clean repo state before running |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have the feeling this will create some controversy, but hear me out. I'm fully aware that ignoring a dirty git state can introduce some unwanted behaviour; files that are not tracked could still end up in a published package, which likely nobody ever wants to happen. However, the situation is very different when working in a monorepo that contains multiple packages. A dirty state in package B would prevent package A being published. This flag helps working around that.
Let me know what you think or feel free to close this.