Detach non-wait PowerShell launches - #370
Conversation
|
Could you also set I double checked the Node docs, and on Windows a detached child process gets its own console window, while And make sure you test manually in PowerShell after this to confirm it works fine. I want to see a screenshot of it too, to confirm, since this PR is clearly AI generated and I don't really trust it. |
Set windowsHide when detaching non-wait PowerShell launches on Windows, and assert the spawn option in the Windows regression test.
|
Updated in Local validation run on macOS:
I cannot provide the requested PowerShell screenshot from this macOS environment; that manual Windows validation still needs to be done on a Windows machine. |
|
As I expected, just AI slop. |
Summary:
process.platformmocked towin32and verifies the spawn optionsTests:
npm_config_cache=/tmp/open-npm-cache npx ava test.js --match="detaches PowerShell launches when not waiting on Windows"npm_config_cache=/tmp/open-npm-cache npx ava test.js --match="app launches resolve before close without fallback" --match="detaches PowerShell launches when not waiting on Windows"npm_config_cache=/tmp/open-npm-cache npm testgit diff --checkFixes #367