Repository navigation
fix(readme): stop the heading rule from cutting through the mascot - #106
Merged
Merged
Conversation
GitHub gives every h1 a full-width bottom border, and the mascot floated in the heading's band, so that rule ran straight through the mascot. The old opaque dark disc hid it; once the mascot became transparent the line showed. GitHub strips the CSS that could remove the h1 border, so instead move the mascot to just after the heading — it now floats beside the intro, below the rule, and nothing crosses it. Heading keeps its underline; mascot stays top-right.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitHub gives every
<h1>a full-width bottom border, and the mascot floated in the heading's band, so that rule ran through the mascot. The old opaque dark disc hid it; once the mascot became transparent, the line showed.GitHub strips the CSS that would remove the h1 border, so instead the mascot moves to just after the heading — it floats beside the intro, below the rule, and nothing crosses it. Heading keeps its underline; mascot stays top-right. Verified against GitHub's real markdown-body CSS.