Repository navigation
Stop counting browsers that are being driven by a script - #432
Merged
Merged
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first funnel numbers were mostly us.
Two days in: 13 editor opens, 12 of them on the kept template. Nearly all of that is my own headless verification navigating to /editor?template=kept, plus two exports from the same checks. A number that counts the people testing the product is worse than no number, because somebody will act on it.
navigator.webdriveris set by Chrome's remote debugging and by every automation framework, so the four counts now return early when it is true.Verified by running the same scripted session twice: against production, which does not have this yet, it sent editor_opened, first_edit, export_started and export_finished; against a local production build with it, it sent nothing at all.
This does not clean the two days already recorded. Counts are kept per day, so tomorrow's are honest, and I have noted on #421 which of today's are mine.
vitest 707 of 707.