Repository navigation
Add Weft, the first of the portfolio pack - #433
Merged
Merged
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First of the three in #413. One site, not a pack: each one lands on its own and is judged against #418 before the next starts.
Weft is a documentary photographer who shoots water-powered weaving sheds. Nothing in it is reusable on another template, which is the test #418 sets: Instrument Serif with Inter Tight appears nowhere else in the catalogue, nor does indigo with madder, and a 2px radius against the 6 to 18px everything else uses.
The copy names eleven mills with four still turning, forty minutes of usable light through the roof vents, editions of twelve printed in Ahmedabad, and a licensing condition that the caption names the mill. A section on what he will not photograph, weddings and restaged sheds, is there because turning work down is the most characteristic thing a working photographer says.
Measured on a production build. Site: headline 14.16:1 desktop and 12.84:1 phone, eyebrow 8.31:1, the call to action 6.24:1. Background moves as you scroll, madder at the top to indigo at the middle, nothing scrolls sideways at either width, no console errors. Gallery card: text 15.01:1 against its own background, mean luma 28, which sits between Northlight at 18 and Kept at 59, so it reads as a card rather than a dark rectangle.
The README's two counts move to 23; the test from #406 caught the second one.
A probe fix came with this: the contrast tool spread a crop's luminance array into Math.min, which overflows the stack on a full-width heading, so it now loops. The phone number above was measured before that and the desktop one after, which is why both appear.
tsc and eslint clean, vitest 707 of 707.