Repository navigation
Title a one page export with the site name on the path the editor uses - #435
Merged
Merged
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fix in #434 only covered half the paths in, and the half nobody uses.
An export built from
sectionsstopped saying "Home" in the browser tab. The editor does not sendsections; it sends a page list whose lone page is called Home, so every export made the way people actually export still carried<title>Home</title>in the tab and in the share card. I found it by downloading a ZIP from the live editor and opening it, rather than by reading the diff I had just written.The title is now set where the page list is final, so both paths get it, with a test for each.
vitest 717 of 717.