Repository navigation
Take Pare back out: a light palette on this geometry reads as a blank page - #438
Merged
Merged
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts the template from #437. The engine change stays; the template goes.
Measured on production across five pages: every page sits at a mean brightness of 20 to 30, and /templates/pare sits at 237. With the geometric shapes drawn at 8 to 20 percent alpha, a light palette produces a near-white page whose background barely moves. On a dark page that restraint reads as deliberate. On a white one it reads as a page that failed to load, which is the opposite of what a product selling cinematic scroll sites should put in its own catalogue.
I had the number before I shipped it. The background moved across a spread of 9 to 22 luminance steps, and I talked myself into it by comparing against forge-devtool, which is flat at 0. The right comparison was not another template's weakness, it was whether somebody opening the page would think it was broken.
What stays:
baseFill, which lets a light palette paint its own ground rather than being painted over by a hardcoded near-black, with its tests. The catalogue is dark again and a test asserts that, so the capability is there when a light template is designed to use it. The footer fix from the same PR stays too: the legal line no longer dims an already translucent colour twice, which was a real 3.73:1 on any light page.A light template is still worth having. It needs shapes that read on a pale ground, not the same geometry with the colours swapped.
vitest 725 of 725, README back to 23.