Conversation
andre-senna
approved these changes
Mar 11, 2026
--config=FILE argument--config=FILE argument
andre-senna
approved these changes
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Introduces a JSON-based configuration file for DAS services and a
--config=FILECLI argument forbus_nodeandbus_client. Configuration is merged so that CLI-provided values override the config file.Changes
JsonConfig– Wrapper over the parsed JSON with schema version and path-based access (at_path("atomdb.redis.port")), plusget_or<T>(default)for optional values.JsonConfigParser– Loads and parses the config file (with optional validation).config/example.json– Example config covering atomdb (Redis, MongoDB, MorkDB, remote peers), agents/endpoints, and ports.CLI integration
bus_nodeandbus_clientaccept--config=FILE. If omitted, the default config path is used.Wiring
bus_nodeuses the config for service endpoints, ports, atomdb type, Redis/MongoDB/MorkDB settings, and remote AtomDB peers.RemoteAtomDBandPropertiesare updated to consume the new config (includingremote_peersand related fields).Tests
config_parser_test– Unit tests for the JSON config parser (path lookup,get_or, schema, etc.).remote_atomdb_test– Adjusted to work with the new config-based setup.Notes
MODULE.bazel(rules_kotlinarchive_override) is out of scope for this PR and can be handled separately.