Open
Conversation
… all versions of Python (Zulko#1185)
galzand
force-pushed
the
make-read-chunk-to-return-on-error
branch
2 times, most recently
from
5186c83 to
db19920
Compare
moviepy/audio/io/readers.py
Outdated
| L = self.nchannels*chunksize*self.nbytes | ||
| s = self.proc.stdout.read(L) | ||
| out, err = self.proc.communicate(timeout=15) | ||
| if err == b'': |
Collaborator
Author
There was a problem hiding this comment.
py2 works for that problematic creative url so didn't know if we should change anything there...
moviepy/audio/io/readers.py
Outdated
| s = out | ||
| else: | ||
| raise ValueError("Error occurred: {}".format(err[:200])) | ||
| # s = self.proc.stdout.read(L) |
| for std in [ self.proc.stdout, | ||
| self.proc.stderr]: | ||
| std.close() | ||
| self.proc.wait() |
moviepy/video/io/VideoFileClip.py
Outdated
|
|
||
| # Make a reader | ||
| pix_fmt = "rgba" if has_mask else "rgb24" | ||
| self.filename = None |
Collaborator
Author
There was a problem hiding this comment.
So for the close() function is finds the reader even if we fail during its code...
|
|
||
|
|
||
| def test_shallow_copy(): | ||
| """Call a function which uses @outplace |
| "imageio_ffmpeg>=0.2.0; python_version>='3.4'", | ||
| 'tqdm>=4.11.2,<5.0', | ||
| "numpy>=1.17.3; python_version!='2.7'", | ||
| "numpy>=1.16.6; python_version!='2.7'", |
There was a problem hiding this comment.
Do we really need this? how does it works before the changes?
Collaborator
Author
There was a problem hiding this comment.
the version of numpy we use in py3 in singular is 1.16.6
so I didn't want that by installing it, it would install a newer numpy version...
SingularVlad
approved these changes
Jun 4, 2024
galzand
force-pushed
the
make-read-chunk-to-return-on-error
branch
from
65dd62c to
03f758a
Compare
SingularVlad
approved these changes
Jun 4, 2024
galzand
force-pushed
the
make-read-chunk-to-return-on-error
branch
from
a02556c to
2b33890
Compare
galzand
force-pushed
the
make-read-chunk-to-return-on-error
branch
2 times, most recently
from
b6923a8 to
d04edbe
Compare
galzand
force-pushed
the
make-read-chunk-to-return-on-error
branch
from
e95b2e7 to
8e03d3f
Compare
galzand
force-pushed
the
make-read-chunk-to-return-on-error
branch
from
8e03d3f to
202b2d5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.