[BUGFIX] switch to excel package: phpoffice/phpspreadsheet#37
[BUGFIX] switch to excel package: phpoffice/phpspreadsheet#37lochmueller wants to merge 1 commit into
Conversation
|
@sirdiego Do you need more information for this PR? |
|
@lochmueller yeah see my review comment above |
|
Hmm... I saw no comment?! |
| } | ||
|
|
||
| $filename = GeneralUtility::getFileAbsFileName($this->filepath); | ||
| $filename = Environment::getPublicPath() . $this->filepath; |
There was a problem hiding this comment.
Hi @lochmueller,
why did you change this line? This would NOT have the same effect. I think we originally used this call to e.g. resolve "EXT:" prefixes, when we now just concatenate this with the filepath that would be something completely different. getFileAbsFileName is also not deprecated 🤔
I'd like to have a little more input on this, thanks!
|
Hey @sirdiego the problem in my case was, that "$this->filepath" starts with a "/" but was relative to the docroot. As result the GeneralUtility::getFileAbsFileName() remove the path, because it is no "real" absolute path. I think there are changes in the path handling between the versions. |
2 participants
No description provided.