Build with 6.3.3#167
Merged
Merged
Conversation
joXemMx
commented
Oct 15, 2025
joXemMx
commented
Collaborator
- updated client libraries for SIRIUS v6.3.3
- new generator for Python
- a bunch of bugfixes
- automated test pipelines working again
- some quality of life changes, e.g. Helper class
* Auto-Updated OpenAPI Clients * Auto-Generated RSirius Manual * add all missing apis * move missing test stubs into classes * move missing test stubs into classes also for R --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: joXemMx <jonas.em@t-online.de>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…n templates and api spec!
…generator@071540f55a6a69471a118446dc05e76a59de0940)
…vectors" for lists of characters
…ated tests (#164) Important changes for future reference: - select_header in api_client.mustache needed indexing adjustment [[1]] instead of [1] - tomato_small.sirius was moved as prerelease asset for download via wget, as university cloud does not allow download from link anymore * error 423 seems tomato_small is locked, may be due to rights * add missing tests * fix filename * still need to load Rsirius (NOT done automatically by testthat) * remove debug prints * explicitly set sirius_port * use custom multireporter * remove deliberate fail * remove old TODO * quick change to cache 6.3.3-SNAPSHOT specifically * use wget * fix list indexing in select_header * set await_deletion for job deletion * reset update-api for now * non-verbose wget
…aryMatchesPaged (data.frame deserialization issues)
…aryMatchesPaged (data.frame deserialization issues) in mustache file
…a bug with additional json parameters
Collaborator
Author
|
Comment: Tests fail here as the main does not have SIRIUS 6.3.3 (or any other version) cached, but tests just passed on the branch itself so we can merge regardless. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.