fix(timer): show days in formatUsageDuration for durations >= 24h#228
Open
Jaahuo wants to merge 2 commits intosirmalloc:mainfrom
Open
fix(timer): show days in formatUsageDuration for durations >= 24h#228Jaahuo wants to merge 2 commits intosirmalloc:mainfrom
Jaahuo wants to merge 2 commits intosirmalloc:mainfrom
Conversation
Durations of 24+ hours now display a days component instead of raw hours (e.g. "1d 12hr 30m" instead of "36hr 30m"). Applies to both normal and compact formats. Fixes sirmalloc#210.
…ration Unify compact/normal branches into a single code path differing only in hour label and separator. Zero duration now displays "0m" instead of "0hr"/"0h".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
formatUsageDuration()now displays a days component for durations >= 24 hours (e.g.1d 12hr 30minstead of36hr 30m)1d12h30min compact mode)0minstead of0hr/0hFixes #210
Test plan
1d 1hr,1d 12hr 30m,7d)1d1h,1d12h30m,7d)0min both modesbun run lintpasses