fix(release): add missing security-events: write permission - #25
Merged
Merged
Conversation
docker-release.yml declares security-events: write unconditionally at its own top level (only exercised when scan_image=true), and GitHub validates a caller's granted permissions against that declaration statically, regardless of which steps actually run. Dropping it broke the first real release.yml run: Error calling workflow '.../docker-release.yml@main'. The workflow is requesting 'security-events: write', but is only allowed 'security-events: none'. See sisques-labs/workflows#75 for the corrected upstream comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the exact
startup_failurefrom the first real run ofrelease.yml:docker-release.ymldeclaressecurity-events: writeunconditionally at its own top level (only exercised whenscan_image: true), and GitHub validates a caller's granted permissions against that declaration statically — regardless of which steps actually run. This permission got dropped whenrelease.ymlwas simplified forbump_mode: promote(#24), since it looked unnecessary withoutscan_image. Root cause + upstream comment fix tracked in sisques-labs/workflows#75.Adds
security-events: writeback to both the top-level and job-levelpermissions:blocks.Test plan
actionlintcleanrelease.ymlwith no inputs — should now actually start and complete