Fixed misaligned paddings when formats other than prefixed hex are used#80
Open
firefish111 wants to merge 3 commits intositkevij:masterfrom
Open
Fixed misaligned paddings when formats other than prefixed hex are used#80firefish111 wants to merge 3 commits intositkevij:masterfrom
firefish111 wants to merge 3 commits intositkevij:masterfrom
Conversation
Author
|
Just committed to fix the linter errors |
Author
|
Added a unit test to check for misaligned padding |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a line is shorter than the specifies column width (
-c), and padding is required, the padding amount per byte was hardcoded to5, which corresponds to the width of one prefixed hex byte plus a space. This causes misalignment when other formattings are used.This fix selects the appropriate padding width based on the format type.