fix: address PR #91 code review findings for --list/--dry-run - #92
Merged
Merged
Conversation
Propagate the tabwriter Flush error in writeDryRunFile instead of suppressing it with nolint, hint that --dry-run's empty result may be due to the incremental filter, and warn on stderr when --list is combined with flags that it silently ignores.
golangci-lint's wsl_v5 linter requires blank line above a range loop when no variable is shared with the immediately preceding statement.
Contributor
🧬 Mutation Testing Results✅ Quality Gate: PASSED Overall Mutation Score: 38.3% Files with Mutations
Generated by gomu mutation testing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up fixes for issues found in review of #91 (already merged):
writeDryRunFileno longer swallows the tabwriterFlush()error vianolint; it now returns and propagates it.--dry-runnow hints that an empty result may be due to the--incrementalfilter (default true), suggesting--incremental=false.gomu run --listnow warns on stderr when combined with other run flags (e.g.--output) that it silently ignores.Test plan
go build ./...go vet ./...gofmt -l .go test ./...