Repository navigation
fix(browser): correctly resolve client certificate prompts - #349
Merged
Merged
Conversation
sk2andy
approved these changes
Nov 9, 2026
sk2andy
left a comment
Owner
There was a problem hiding this comment.
Reviewed the one-line change against the GeckoView 159 API and bundled ClientAuthDialogService. confirm(null) correctly returns an explicit null alias without selecting a client certificate. An isolated check of the original callback reproduces the TypeError with the old null response and reaches certificateChosen with the new response. No blocking findings. Both CI checks passed. Android build and live CommBank navigation were not rerun during this review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
https://www.commbank.com.au/digital/home-buying/calculator/home-loan-repayments times out after about 30 s with
GeckoView:OnLoadError.Root cause
www.commbank.com.ausends an optional TLSCertificateRequest(openssl s_clientshows "Acceptable client certificate CA names").www.my.commbank.com.auand the other CommBank hosts do not.PromptDelegate.onRequestCertificate. Candy answered withprompt.dismiss(), which resolves the prompt with a null result.ClientAuthDialogService.sys.mjsthen readsresult.aliasand throws (TypeError: can't access property "alias", result is null, seen in logcat). Because of that,callback.certificateChosenis never called and the TLS handshake stalls.Fix
Answer with
prompt.confirm(null).CertificateRequest.confirmdocuments a null alias as "no certificate selected", so the handshake continues without a client certificate. This is the same behaviour as before for sites that require a certificate: those sites still reject the connection. Candy never offered a KeyChain picker.Testing
Tested on an emulator (API 35, debug build, GeckoView 157), although there were some extra patches applied:
PageStart, thenPrompt, then the ClientAuth TypeError, thenOnLoadErrorabout 30 s later. The tab stays at about:blank.PageStart, thenPrompt, thenPageStopafter about 5 s, with no error. The calculator renders.