Cancel the root context on interrupt and termination signals - #178
Merged
Conversation
Both binaries called cobra's cmd.Execute(), which gives cmd.Context() a plain context.Background() that is never cancelled. In the sidecar this left the graceful-shutdown block (server.Shutdown with a 5s timeout) and the tracer cleanup defers unreachable on a normal docker stop: Go terminates on SIGTERM without running them. Wire signal.NotifyContext(os.Interrupt, SIGTERM) into a root context and pass it via cmd.ExecuteContext, so cmd.Context() cancels on a stop signal and the existing errgroup-driven shutdown runs. The CLI is largely covered by bubbletea already, but is switched too for consistency and deterministic teardown of the collector goroutine.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both binaries called cobra's cmd.Execute(), which gives cmd.Context() a plain context.Background() that is never cancelled. In the sidecar this left the graceful-shutdown block (server.Shutdown with a 5s timeout) and the tracer cleanup defers unreachable on a normal docker stop: Go terminates on SIGTERM without running them.
Wire signal.NotifyContext(os.Interrupt, SIGTERM) into a root context and pass it via cmd.ExecuteContext, so cmd.Context() cancels on a stop signal and the existing errgroup-driven shutdown runs. The CLI is largely covered by bubbletea already, but is switched too for consistency and deterministic teardown of the collector goroutine.