Harden the USDT note parser against malformed input - #179
Merged
Conversation
getLocationFromProbe parsed .note.stapsdt without bounds checks, so a truncated or corrupt extension binary could crash the sidecar during runtime discovery: an unterminated provider or probe string made bytes.IndexByte return -1 and the following slice expression panic, a negative descsz wrapped through uint64 into a multi-gigabyte allocation, and a 32-bit ELF drove Uint64 across a four-byte field. Reject non-64-bit binaries and out-of-range namesz/descsz up front, and extract the descriptor-body decode into parseNoteDesc, which guards the address-field length and both string terminators and returns an error instead of panicking. Add unit tests for the rejects and a fuzz target asserting no descriptor body can panic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
getLocationFromProbe parsed .note.stapsdt without bounds checks, so a truncated or corrupt extension binary could crash the sidecar during runtime discovery: an unterminated provider or probe string made bytes.IndexByte return -1 and the following slice expression panic, a negative descsz wrapped through uint64 into a multi-gigabyte allocation, and a 32-bit ELF drove Uint64 across a four-byte field.
Reject non-64-bit binaries and out-of-range namesz/descsz up front, and extract the descriptor-body decode into parseNoteDesc, which guards the address-field length and both string terminators and returns an error instead of panicking. Add unit tests for the rejects and a fuzz target asserting no descriptor body can panic.