Give the broadcaster a shutdown path - #180
Merged
Merged
Conversation
The broadcaster's run goroutine looped forever with no way to stop, and Subscribe/Unsubscribe blocked on unbuffered channels handed to it. This was latent while nothing cancelled the process context, but now that a signal cancels it the sidecar's shutdown drives this path: server.Shutdown waits for the streaming handlers to return, and they only return once their subscriber channel closes. Run now takes a context and, on cancellation, closes every subscriber channel and returns, so blocked stream handlers unblock and server.Shutdown completes instead of waiting out its timeout. Subscribe, Unsubscribe and ProcessTrace select on a done channel so they no longer block once the loop has stopped; Subscribe hands back a closed channel after shutdown. The broadcaster is built from the errgroup context, and the tests pass one that ends with the test. Adds a shutdown test asserting subscribers are closed and the API stops blocking, and moves the existing tests onto a cancellable context.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The broadcaster's run goroutine looped forever with no way to stop, and Subscribe/Unsubscribe blocked on unbuffered channels handed to it. This was latent while nothing cancelled the process context, but now that a signal cancels it the sidecar's shutdown drives this path: server.Shutdown waits for the streaming handlers to return, and they only return once their subscriber channel closes.
Run now takes a context and, on cancellation, closes every subscriber channel and returns, so blocked stream handlers unblock and server.Shutdown completes instead of waiting out its timeout. Subscribe, Unsubscribe and ProcessTrace select on a done channel so they no longer block once the loop has stopped; Subscribe hands back a closed channel after shutdown. The broadcaster is built from the errgroup context, and the tests pass one that ends with the test.
Adds a shutdown test asserting subscribers are closed and the API stops blocking, and moves the existing tests onto a cancellable context.