Close ring-buffer readers on tracer init failure - #181
Merged
Conversation
The FPM tracer opened the events reader and then the Drupal cache reader; if the second open failed, the first was never closed, because ringreader.Run, which takes ownership of both, was never reached. Across the collector supervisor's restart loop a recurring failure leaked a kernel ring-buffer mapping each attempt. Close the events reader on that error path. ringreader.Run also leaked the readers it was handed if source validation failed before its cleanup goroutine took over. Close all provided readers on the validation-failure path too, via a shared closeAll helper, and add a test. The single-reader CLI and Node tracers hand their reader straight to Run with no intervening fallible step, so this covers them as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The FPM tracer opened the events reader and then the Drupal cache reader; if the second open failed, the first was never closed, because ringreader.Run, which takes ownership of both, was never reached. Across the collector supervisor's restart loop a recurring failure leaked a kernel ring-buffer mapping each attempt. Close the events reader on that error path.
ringreader.Run also leaked the readers it was handed if source validation failed before its cleanup goroutine took over. Close all provided readers on the validation-failure path too, via a shared closeAll helper, and add a test. The single-reader CLI and Node tracers hand their reader straight to Run with no intervening fallible step, so this covers them as well.