Label the trace stream as NDJSON, not SSE - #182
Merged
Conversation
The /v1/traces handler advertised Content-Type text/event-stream but wrote newline-delimited JSON: json.NewEncoder emits one object per line, not the 'data:'-prefixed, blank-line-separated frames SSE requires. A conformant SSE client reads the whole response as one unterminated event. The Compass CLI works only because it parses the body as line-delimited JSON and never checks the content type. Relabel the response as application/x-ndjson, which matches the bytes on the wire; no wire change is needed and the CLI is unaffected. Document the format on the --uri row in the README.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The /v1/traces handler advertised Content-Type text/event-stream but wrote newline-delimited JSON: json.NewEncoder emits one object per line, not the 'data:'-prefixed, blank-line-separated frames SSE requires. A conformant SSE client reads the whole response as one unterminated event. The Compass CLI works only because it parses the body as line-delimited JSON and never checks the content type.
Relabel the response as application/x-ndjson, which matches the bytes on the wire; no wire change is needed and the CLI is unaffected. Document the format on the --uri row in the README.