fix(journal): correct ordinal suffix lookup and add regression tests#1
Merged
skridlevsky merged 1 commit intoFeb 15, 2026
Conversation
Contributor
Author
|
@skridlevsky can you take a look when you get a chance? |
Owner
|
@manfredlift Great catch - thanks for the fix! Merged. |
donkeykong91
pushed a commit
to donkeykong91/graphthulhu
that referenced
this pull request
Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes journal_range page lookup for Logseq journals with ordinal date suffixes (for example Feb 15th, 2026) and adds regression tests.
Problem
JournalRange currently tries:
In Go time formatting, nd is treated as a literal string, so dates like the 15th are formatted as Feb 15nd, 2026 instead of Feb 15th, 2026.
As a result, valid Logseq journal pages are missed and entriesFound can incorrectly be 0.
Changes
Result
journal_range now correctly matches standard Logseq journal names with ordinals, including pages like:
Notes
This PR is intentionally scoped to suffix generation and lookup behavior; it does not change query semantics beyond fixing date-name matching.