Skip to content

feat: allow nested list/tuple input/output and None type - #200

Open
cijinsama wants to merge 2 commits into
sksq96:masterfrom
cijinsama:master
Open

feat: allow nested list/tuple input/output and None type#200
cijinsama wants to merge 2 commits into
sksq96:masterfrom
cijinsama:master

Conversation

@cijinsama

Copy link
Copy Markdown

Main change features:

  • Allow nested list/tuple input/output like
    def forward(self, x: torch.Tensor, y: List[Tuple[torch.Tensor, torch.Tensor, ...]]):
        ...
        return c, [(mean_1, var_1, weight_1), (mean_2, var_2, weight_2), ...]
  • Allow input/output with None in list/tuple

@cijinsama cijinsama closed this Jan 28, 2024
@cijinsama cijinsama reopened this Jan 28, 2024

@willyfh willyfh left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left few comments in the file changes. In addition, is it appropriate to use a public function instead of the private one? (Using _ in front of the function name)

Comment thread torchsummary/torchsummary.py Outdated
Comment thread torchsummary/torchsummary.py Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants