FIX: validate horizon parameter in fit_predict, predict, and fit_predict_async tools#355
Open
Sandrakimiring wants to merge 6 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes #354
What does this implement/fix? Explain your changes.
Three tools accepted
horizon: intbut passed it through with no validation:fit_predict_tool— passed bad horizon to executor silentlypredict_tool—range(1, horizon+1)producedfh=[]when horizon≤0fit_predict_async_tool— created a background job with a bad horizonAdded a guard as the first check in each function — before any executor,
asyncio, or job-manager code is reached. Values less than 1 now return:
{"success": False, "error": "horizon must be a positive integer."}Does your contribution introduce a new dependency? If yes, which one?
No new dependencies.
What should a reviewer concentrate their feedback on?
The 3 guards in
src/sktime_mcp/tools/fit_predict.pyand the 9 newtests in
TestHorizonValidationintests/test_core.py.PR checklist