Restore the warm welcome.

[jaydeetay]

Description

Type of Change

• Bug fix
• New feature (Sky Map team only)
• Translation (new or updated)
• Documentation
• Refactoring / code cleanup
• Dependency upgrade
• Other

Checklist

• I've read the contributing guidelines
• For major changes, I've emailed skymapdevs@gmail.com first
• I've run the unit tests with ./stardroid-v1/gradlew :app:test
• I've tested on a device/emulator if applicable
• If I have multiple commits, I've squashed them into one

No need to update CHANGELOG.md - we'll get Claude to do that when we cut a release.

Notes for Reviewers

[gemini-code-assist]

Code Review

This pull request removes the WARM_WELCOME_ENABLED feature flag, effectively making the onboarding flow a permanent feature of the application. The changes include removing conditional checks in DynamicStarMapActivity and SplashScreenActivity, and deleting the NoSensorsDialogFragment in favor of a Toast notification. Feedback suggests that replacing the dialog with a Toast removes the 'Don't show again' option for missing sensor warnings, which may lead to repetitive notifications for users who bypass the splash screen or complete the tutorial manually.

[gemini-code-assist]

The replacement of NoSensorsDialogFragment with a Toast removes the 'Don't show again' option. While the WarmWelcomeActivity flow is intended to suppress this warning by setting the NO_WARN_ABOUT_MISSING_SENSORS preference, users who bypass the splash screen (e.g., via a search intent or home screen shortcut) will see this Toast on every launch. Furthermore, completing the tutorial manually does not currently set this preference (based on the logic in WarmWelcomeActivity.kt), leaving these users with no way to permanently dismiss the warning. Consider ensuring the preference is updated whenever the tutorial is completed, regardless of how it was invoked.