feat(rtk): position saving and reloading#104
feat(rtk): position saving and reloading#104zarcell wants to merge 74 commits intoskybrush-io:devfrom
Conversation
isti115
changed the title
isti115
changed the title
zarcell
changed the title
There was a problem hiding this comment.
I tried to provide inline suggestions for all the optional nitpicks, so they can be batch accepted without any extra hassle, as I didn't want to introduce any unnecessary burden requiring further effort on your part. If it still seems too much, I can try to either mark the actually important comments separately or commit some of the trivial changes myself.
isti115
left a comment
isti115
left a comment
There was a problem hiding this comment.
I tried to provide inline suggestions for all the optional nitpicks, so they can be accepted without any extra hassle, as I didn't want to introduce any unnecessary burden requiring further effort on your part. If it still seems too much, I can try to either mark the actually important comments separately or commit some of the trivial changes myself.
isti115
left a comment
isti115
left a comment
There was a problem hiding this comment.
I tried to provide inline suggestions for all the optional nitpicks, so they can be accepted without any extra hassle, as I didn't want to introduce any unnecessary burden requiring further effort on your part. If it still seems too much, I can try to either mark the actually important comments separately or commit some of the trivial changes myself.
isti115
left a comment
isti115
left a comment
There was a problem hiding this comment.
I tried to provide inline suggestions for all the optional nitpicks, so they can be accepted without any extra hassle, as I didn't want to introduce any unnecessary burden requiring further effort on your part. If it still seems too much, I can try to either mark the actually important comments separately or commit some of the trivial changes myself.
Co-authored-by: István Donkó <istvan.donko@gmail.com>
src/features/rtk/utils.ts
Outdated
| return hasECEF && (surveyedCoordinateValid || typeof accuracy === 'number'); | ||
| // Consider fix valid only with ECEF position, valid-coordinate flag, and numeric accuracy. | ||
| return hasECEF && surveyedCoordinateValid && typeof accuracy === 'number'; |
There was a problem hiding this comment.
Notes for @ntamas when review is done: the LED on the RTK widget shows the surveys current state, which can be misleading when using fixed coordinates from server config or even from this feature. One solution can be a FIXED bit in the survey flags that the Live can handle to show exactly what is happening to the user.
3 participants
This still needs testing on field, use this only for code review!